Repository navigation
src: add eslint configuration and npm script - #55
Merged
Merged
Conversation
lance
commented
Apr 14, 2020
Member
Author
|
@fabiojose I am ready to remove the WIP label from this, however it seems that something within |
lance
marked this pull request as ready for review
April 21, 2020 22:16
Contributor
|
@lance, please fix that conflicts. |
Automatically fixed > 2000 issues. The remaining 200+ issues need to be fixed by hand. Additionally, all strings are double quotes which is not typically standard and I wonder about fixing that too. Signed-off-by: Lance Ball <lball@redhat.com>
Member
Author
|
@fabiojose conflicts are resolved. This is ready for review. |
grant
approved these changes
Apr 25, 2020
grant
left a comment
grant
left a comment
Member
There was a problem hiding this comment.
This was one of the issues faced when looking at this repo. Glad to see a PR for fixing this!
Member
Author
|
@fabiojose ping - any chance this can land soon? There are lots of changes in this PR, and the longer it sits the more difficult it makes landing new PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The linting configuration is based on
eslint-recommendedwith some customization for arrow functions, double quoted strings and a few other things.Running
npx standardx --fixautomatically fixed > 2000 issues. The remaining 200+ issues needto be fixed by hand. Additionally, all strings are double quotes which is not typically standard and I wonder about fixing that too.
This is a potentially large change since it touches most files, marking as WIP.
Fixes: #54
Signed-off-by: Lance Ball lball@redhat.com